Enable Reactant AD through sequence discretization - #924
Open
KookiesNKareem wants to merge 5 commits into
Open
Conversation
cncastillo
marked this pull request as ready for review
July 31, 2026 20:15
This was referenced Jul 31, 2026
KookiesNKareem
marked this pull request as draft
August 1, 2026 19:01
KookiesNKareem
force-pushed
the
branch/reactant-discretize-ad
branch
from
August 2, 2026 01:59
db10f1e to
09f0468
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## branch/reactant-parallel-ad #924 +/- ##
===============================================================
- Coverage 91.57% 88.24% -3.33%
===============================================================
Files 146 146
Lines 7534 7495 -39
===============================================================
- Hits 6899 6614 -285
- Misses 635 881 +246
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
KookiesNKareem
force-pushed
the
branch/reactant-discretize-ad
branch
from
August 2, 2026 15:59
c4bc57f to
eca8bbf
Compare
KookiesNKareem
marked this pull request as ready for review
August 2, 2026 18:53
cncastillo
requested changes
Aug 10, 2026
Member
There was a problem hiding this comment.
As mentioned in other PRs probably not needed.
Collaborator
Author
There was a problem hiding this comment.
problem is that when reactant is compiling with the traced array it doesn't know the numerical values so it can't evaluate is_on the same way
Comment on lines
+20
to
+30
| @inline _scalar_getindex(x, i) = x[i] | ||
| @inline _scalar_setindex!(x, value, i) = setindex!(x, value, i) | ||
|
|
||
| function _zero_pad_samples(A) | ||
| out = similar(A, length(A) + 2) | ||
| fill!(out, zero(eltype(A))) | ||
| for i in eachindex(A) | ||
| _scalar_setindex!(out, _scalar_getindex(A, i), i + 1) | ||
| end | ||
| return out | ||
| end |
Comment on lines
+64
to
+65
| length(A) == 1 && (A = A[[1, 1]]) | ||
| A = _zero_pad_samples(A) |
Member
There was a problem hiding this comment.
This one is kind of sketchy, probably not needed. What about, could the problem be the [el1 ; ... ; eln] in another PR you changes something to [el1, ..., eln]
Comment on lines
85
to
89
| if length(seq) == 1 | ||
| values = sample_sequence_block(seq, 1; sampling_rule, motion_times=block_global_event_times(T0, 1, global_event_times), freq_in_phase) | ||
| return _with_adc_start_padding(values) | ||
| end | ||
| out = DiscreteSequence() |
Member
There was a problem hiding this comment.
why define a special case for length(seq) == 1? When is this used? Also _with_adc_start_padding and _prepend_sample are probably not needed..
KookiesNKareem
force-pushed
the
branch/reactant-discretize-ad
branch
from
August 10, 2026 16:53
7f6640c to
7ea4dab
Compare
KookiesNKareem
force-pushed
the
branch/reactant-discretize-ad
branch
from
August 19, 2026 23:45
1c8ddb5 to
e8bbd9c
Compare
KookiesNKareem
force-pushed
the
branch/reactant-discretize-ad
branch
from
August 21, 2026 04:57
98cacf3 to
96387ed
Compare
KookiesNKareem
force-pushed
the
branch/reactant-discretize-ad
branch
from
August 24, 2026 21:52
96387ed to
122b9e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KomaMRIBaseReactant extension for traced RF arrays while preserving the existing native discretization pathdiscretize,get_sim_ranges, and theBlochSimpletime iteratorValidation
16/16KomaMRIBase:767/767KomaMRICoreCPU suite:448/448KomaMRIFiles:24448/244484/4; new discretize + ADC + iterator test2/2rtol=1e-8,atol=1e-10git diff --checkStacked on #922.